From 6af4879ac29414287b0dc6b9150ab93c5cb78809 Mon Sep 17 00:00:00 2001 From: Andrew Branson Date: Fri, 26 Sep 2014 13:51:00 +0200 Subject: More FindBugs recommendations --- .../com/c2kernel/lifecycle/instance/WfVertexOutlineCreator.java | 8 ++++---- src/main/java/com/c2kernel/persistency/TransactionManager.java | 1 - src/main/java/com/c2kernel/utils/GTimeStampComparator.java | 3 ++- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/main/java/com/c2kernel/lifecycle/instance/WfVertexOutlineCreator.java b/src/main/java/com/c2kernel/lifecycle/instance/WfVertexOutlineCreator.java index 3ae1730..bc345f9 100644 --- a/src/main/java/com/c2kernel/lifecycle/instance/WfVertexOutlineCreator.java +++ b/src/main/java/com/c2kernel/lifecycle/instance/WfVertexOutlineCreator.java @@ -8,10 +8,10 @@ import com.c2kernel.graph.model.VertexOutlineCreator; public class WfVertexOutlineCreator implements VertexOutlineCreator,Serializable { - private final int mActivityWidth = 130; - private final int mActivityHeight = 60; - private final int mSplitJoinWidth = 60; - private final int mSplitJoinHeight = 25; + private static final int mActivityWidth = 130; + private static final int mActivityHeight = 60; + private static final int mSplitJoinWidth = 60; + private static final int mSplitJoinHeight = 25; @Override public void setOutline(Vertex vertex) diff --git a/src/main/java/com/c2kernel/persistency/TransactionManager.java b/src/main/java/com/c2kernel/persistency/TransactionManager.java index b28a440..0d8e0b1 100644 --- a/src/main/java/com/c2kernel/persistency/TransactionManager.java +++ b/src/main/java/com/c2kernel/persistency/TransactionManager.java @@ -85,7 +85,6 @@ public class TransactionManager { public void put(ItemPath itemPath, C2KLocalObject obj, Object locker) throws ClusterStorageException { Object tempLocker = null; ArrayList lockerTransaction; - String path = ClusterStorage.getPath(obj); synchronized(locks) { // look to see if this object is already locked diff --git a/src/main/java/com/c2kernel/utils/GTimeStampComparator.java b/src/main/java/com/c2kernel/utils/GTimeStampComparator.java index 8701b0e..7dbbf8d 100644 --- a/src/main/java/com/c2kernel/utils/GTimeStampComparator.java +++ b/src/main/java/com/c2kernel/utils/GTimeStampComparator.java @@ -1,10 +1,11 @@ package com.c2kernel.utils; +import java.io.Serializable; import java.util.Comparator; import com.c2kernel.common.GTimeStamp; -public class GTimeStampComparator implements Comparator { +public class GTimeStampComparator implements Comparator, Serializable { @Override public int compare(GTimeStamp t0, GTimeStamp t1) { -- cgit v1.2.3