From be6b4608bdea970657d0257460ab92874314ca9b Mon Sep 17 00:00:00 2001
From: Andrew Branson <andrew.branson@cern.ch>
Date: Fri, 26 Sep 2014 11:06:51 +0200
Subject: Various problems found by FindBugs

---
 src/main/java/com/c2kernel/process/UserCodeProcess.java | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

(limited to 'src/main/java/com/c2kernel/process/UserCodeProcess.java')

diff --git a/src/main/java/com/c2kernel/process/UserCodeProcess.java b/src/main/java/com/c2kernel/process/UserCodeProcess.java
index cb8ca74..8182f65 100644
--- a/src/main/java/com/c2kernel/process/UserCodeProcess.java
+++ b/src/main/java/com/c2kernel/process/UserCodeProcess.java
@@ -36,7 +36,7 @@ public class UserCodeProcess extends StandardClient implements ProxyObserver<Job
     static boolean active = true;
     ArrayList<String> ignoredPaths = new ArrayList<String>();
     HashMap<String, ErrorInfo> errors = new HashMap<String, ErrorInfo>();
-    HashMap<String, C2KLocalObject> jobs;
+    final HashMap<String, C2KLocalObject> jobs = new HashMap<String, C2KLocalObject>();
 
     public UserCodeProcess(String agentName, String agentPass, String resource) {
         // login - try for a while in case server hasn't imported our user yet
@@ -59,7 +59,6 @@ public class UserCodeProcess extends StandardClient implements ProxyObserver<Job
     @Override
 	public void run() {
         Thread.currentThread().setName("Usercode Process");
-        jobs = new HashMap<String, C2KLocalObject>();
         // subscribe to job list
         agent.subscribe(new MemberSubscription<Job>(this, ClusterStorage.JOB, true));
         while (active) {
@@ -193,7 +192,7 @@ public class UserCodeProcess extends StandardClient implements ProxyObserver<Job
     
 	@Override
 	public void control(String control, String msg) {
-		if (control == MemberSubscription.ERROR)
+		if (MemberSubscription.ERROR.equals(control))
 			Logger.error("Error in job subscription: "+msg);
 	}
 
-- 
cgit v1.2.3