diff options
| author | Andrew Branson <andrew.branson@cern.ch> | 2014-10-03 23:56:29 +0200 |
|---|---|---|
| committer | Andrew Branson <andrew.branson@cern.ch> | 2014-10-03 23:56:29 +0200 |
| commit | c48883b9584a41db39154f3d6370d13b8c8f8018 (patch) | |
| tree | 0dd45f1be966483d47bb1d8fec8a3fb95b1d71e1 /src/main/java/com/c2kernel/lifecycle | |
| parent | b68ea0f2b12c4c5189c5fc7c182a1b242dc63579 (diff) | |
More FindBugs cleanup
Diffstat (limited to 'src/main/java/com/c2kernel/lifecycle')
3 files changed, 6 insertions, 7 deletions
diff --git a/src/main/java/com/c2kernel/lifecycle/WfCastorHashMap.java b/src/main/java/com/c2kernel/lifecycle/WfCastorHashMap.java index 02d467a..922a92d 100644 --- a/src/main/java/com/c2kernel/lifecycle/WfCastorHashMap.java +++ b/src/main/java/com/c2kernel/lifecycle/WfCastorHashMap.java @@ -31,8 +31,8 @@ public class WfCastorHashMap extends CastorHashMap */
public WfCastorHashMap()
{
- put("Show time", new Boolean(true));
- put("Breakpoint", new Boolean(false));
+ put("Show time", true);
+ put("Breakpoint", false);
put("Description", "");
put("Agent Role", "");
put("Agent Name", "");
diff --git a/src/main/java/com/c2kernel/lifecycle/WfVertexDefOutlineCreator.java b/src/main/java/com/c2kernel/lifecycle/WfVertexDefOutlineCreator.java index cf6c04d..d2322d3 100644 --- a/src/main/java/com/c2kernel/lifecycle/WfVertexDefOutlineCreator.java +++ b/src/main/java/com/c2kernel/lifecycle/WfVertexDefOutlineCreator.java @@ -26,10 +26,10 @@ import com.c2kernel.graph.model.VertexOutlineCreator; public class WfVertexDefOutlineCreator implements VertexOutlineCreator
{
- private final int mActivityWidth = 130;
- private final int mActivityHeight = 60;
- private final int mSplitJoinWidth = 60;
- private final int mSplitJoinHeight = 25;
+ private static final int mActivityWidth = 130;
+ private static final int mActivityHeight = 60;
+ private static final int mSplitJoinWidth = 60;
+ private static final int mSplitJoinHeight = 25;
@Override
public void setOutline(Vertex vertex)
diff --git a/src/main/java/com/c2kernel/lifecycle/instance/predefined/agent/SetAgentPassword.java b/src/main/java/com/c2kernel/lifecycle/instance/predefined/agent/SetAgentPassword.java index f54e2a8..3832337 100644 --- a/src/main/java/com/c2kernel/lifecycle/instance/predefined/agent/SetAgentPassword.java +++ b/src/main/java/com/c2kernel/lifecycle/instance/predefined/agent/SetAgentPassword.java @@ -54,7 +54,6 @@ public class SetAgentPassword extends PredefinedStep { } catch (InvalidItemPathException ex) {
throw new InvalidDataException("Can only set password on an Agent. "+item+" is an Item.");
}
- String agentName = targetAgent.getAgentName();
try {
Gateway.getLookupManager().setAgentPassword(targetAgent, params[0]);
|